Skip to content

Fix tests relying on unavailable external services - #6247

Merged
matyhtf merged 1 commit into
masterfrom
fix/replace-httpcan
Sep 22, 2026
Merged

matyhtf merged 1 commit into
masterfrom
fix/replace-httpcan

Conversation

@matyhtf

@matyhtf matyhtf commented Sep 22, 2026

Copy link
Copy Markdown
Member

Summary

  • replace unavailable httpcan.org HTTP endpoints with https://httpbin.io
  • use the nghttp2.org public HTTP/2 test endpoint for the HTTP/2-only connect-twice test because httpbin.io does not negotiate h2
  • keep the BitMEX public WebSocket test and validate its guaranteed subscription acknowledgement and initial partial snapshot instead of requiring 16 traffic-dependent market updates
  • update the cookie assertions for the response shape returned by httpbin.io

Why ssl_2.phpt failed

The WebSocket handshake succeeded with status 101. The test then received the initial BitMEX frames but timed out waiting for an arbitrary total of 16 frames (ETIMEDOUT 110). Subsequent update frames depend on market activity and are not guaranteed within the receive timeout.

Tests

  • all 5 httpbin.io PHPT tests pass
  • swoole_http2_client_coro/connect_twice.phpt passes against nghttp2.org
  • swoole_http_client_coro/websocket/ssl_2.phpt passes against BitMEX

@matyhtf
matyhtf merged commit 2c451c1 into master Sep 22, 2026
35 of 38 checks passed
@matyhtf
matyhtf deleted the fix/replace-httpcan branch September 22, 2026 06:23
@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.03%. Comparing base (f7532a4) to head (2f6cd23).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6247      +/-   ##
==========================================
+ Coverage   84.01%   84.03%   +0.01%     
==========================================
  Files         114      114              
  Lines       18506    18506              
  Branches     3290     3289       -1     
==========================================
+ Hits        15548    15551       +3     
+ Misses       2958     2955       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

matyhtf added a commit that referenced this pull request Sep 22, 2026
matyhtf added a commit that referenced this pull request Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant