Repository navigation
Fix type cast for lockwait - #5862
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 5.1.x #5862 +/- ##
==========================================
+ Coverage 71.48% 71.61% +0.13%
==========================================
Files 105 105
Lines 16144 16144
Branches 2967 2967
==========================================
+ Hits 11540 11561 +21
+ Misses 4549 4527 -22
- Partials 55 56 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@Appla There is a bug here. Your code is correct and has been merged |
matyhtf
pushed a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of lockwait discards the decimal portion of the input. For example, lockwait(1.2) is incorrectly converted to 1 * 1000 = 1000 milliseconds, instead of the expected 1.2 * 1000 = 1200 milliseconds.
This MR is also applicable to the master branch.