Repository navigation
Do not write files atomically in WASI - #1315
Merged
Merged
Conversation
swift-format doesn't support the WebAssembly System Interface (WASI) yet, but this change is just preparation for future support for WASI. In Swift's Foundation, atomic file writing isn't available on WASI since it uses a temporary directory and WASI doesn't have such a concept. Therefore, I made changes to ensure that it isn't used on platforms that don't support atomic writing, such as WASI.
kkebo
requested review from
allevato,
dylansturg,
hamishknight,
hborla and
rintaro
as code owners
October 24, 2026 15:12
allevato
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swift-format doesn't support the WebAssembly System Interface (WASI) yet, but this change is just preparation for future support for WASI.
In Swift's Foundation, atomic file writing isn't available on WASI since it uses a temporary directory and WASI doesn't have such a concept.
Therefore, I made changes to ensure that it isn't used on platforms that don't support atomic writing, such as WASI.
I've verified that
swift testsucceeds for wasm32-unknown-wasip1 in my fork's CI. The fork includes this PR's changes.