ci: adopt shared reusable dev-sync workflow - #643
Merged
Merged
Conversation
Author
CI triageAll checks pass except
Nothing here needs a code change. Note that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Per PLAN-001 (CI/CD standardization), the dev-sync logic — compute next
version from unreleased changie fragments, then create/force-update the
release/vX.Y.Z → X.YPR — is duplicated near-verbatim across the threebackend SDKs. This unit (A7) replaces
supertokens-python's local copy witha thin caller of the shared reusable workflow
supertokens/actions/.github/workflows/dev-sync.yml@main, so theorchestration lives in one place.
Fix
.github/workflows/dev-sync.ymlis now a thin caller. All python-specificbehavior is reproduced exactly via the reusable workflow's inputs, so the
generated release PR is equivalent to before:
python_version: "3.13"→ runsactions/setup-python@v5as before.prepare:runs the old doc steps (pip install pdoc3==0.11.0 -e ".[fastapi,flask,django,drf]"thenmake build-docs) afterchangie batch/merge.add_paths: ".changes/ CHANGELOG.md setup.py supertokens_python/constants.py html/"— identical to the oldgit addline. Cross-checked against.changie.yaml: itsreplacements:block rewrites exactlysetup.pyandsupertokens_python/constants.py, and both are staged (no stale-version-file trap).version_check_hint/post_merge_notereproduce the old PR-body wording verbatim (checklist points atsetup.py/constants.py; after-merge note still says "trigger the Release Pipeline … with branch").secrets: inheritforwardsALL_REPO_PAT(the reusable's one required secret).bumpoverride, triggers (push: [dev]+workflow_dispatch), permissions,and the
run-tests/Skip-Changeloglabels are all unchanged.Tests
No automated test — this is a workflow file.
dev-synctriggers only onpush-to-
devandworkflow_dispatch, so PR CI does not exercise it. Iverified statically:
Not verified
devafter merge — per PLAN-001 this is the required post-merge validation for A6–A8. Recommend confirming the release PR is created/updated correctly on the firstdevpush.Cross-SDK note
supertokens-node(A6) already adopted this reusable workflow ondev;supertokens-golang(A8) is the remaining sibling. One intentional wordingdivergence from node's caller: node's
post_merge_notewas changed to say theRelease Pipeline auto-starts, whereas python's existing behavior says to
trigger it manually with the branch — I preserved python's existing wording to
keep this a faithful extraction, not a behavior change. If the pipeline does
auto-start for python too, that note can be aligned in a follow-up. The
reusable has no
node_versioninput (a node-only concern); N/A here sincepython passes
python_version.CI note
supertokens-python's PR CI has atest-gatethat fails with "No test labelfound" unless the PR carries
run-tests/skip-tests. Applying that label is ahuman triage decision (like
Skip-Changelog), so I've left it — the failure ispre-existing policy, not caused by this change.
Part of PLAN-001.
Fixes #641