Skip to content

fix: persist all messages in multi-step tool calls #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: persist all messages in multi-step tool calls #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 21 additions & 34 deletions app/(chat)/api/chat/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,49 +260,36 @@ export async function POST(request: Request) {
'[POST] [onFinish] User session exists, saving assistant message',
);
try {
const assistantId = getTrailingMessageId({
messages: response.messages.filter(
(message) => message.role === 'assistant',
),
});
console.log(
'[POST] [onFinish] Assistant message ID:',
assistantId,
);

if (!assistantId) {
console.log('[POST] [onFinish] No assistant message found!');
throw new Error('No assistant message found!');
}

console.log('[POST] [onFinish] Appending response messages');
const [, assistantMessage] = appendResponseMessages({
const allResponseMessages = appendResponseMessages({
messages: [message],
responseMessages: response.messages,
});
console.log('[POST] [onFinish] Assistant message prepared:', {
role: assistantMessage.role,
partsCount: assistantMessage.parts?.length || 0,
// Skip index 0 (the original user message) and save ALL
// response messages so that multi-step tool_use / tool_result
// pairs are fully persisted and the conversation history sent
// to Anthropic remains valid.
const messagesToSave = allResponseMessages.slice(1).map(
(msg) => ({
id: msg.id,
chatId: id,
role: msg.role,
parts: msg.parts,
attachments: msg.experimental_attachments ?? [],
createdAt: new Date(),
}),
);
console.log('[POST] [onFinish] Messages to save:', {
count: messagesToSave.length,
roles: messagesToSave.map((m) => m.role),
});

console.log(
'[POST] [onFinish] Saving assistant message to database',
'[POST] [onFinish] Saving all response messages to database',
);
await saveMessages({
messages: [
{
id: assistantId,
chatId: id,
role: assistantMessage.role,
parts: assistantMessage.parts,
attachments:
assistantMessage.experimental_attachments ?? [],
createdAt: new Date(),
},
],
});
await saveMessages({ messages: messagesToSave });
console.log(
'[POST] [onFinish] Assistant message saved successfully',
'[POST] [onFinish] All response messages saved successfully',
);

// Disabled message eviction for now
Expand Down