🐛(frontend) fix search-modal issues#254
Open
jbpenrath wants to merge 1 commit into
Open
Conversation
QuickSearchItem takes an `alwaysShowRight` prop but this right container was only gated to `isDesktop` so on small viewports, no matter the value of `alwaysShowRight` items were hidden. Then we also fix a little style issue with dark theme, the quick search input had the default browser background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuickSearchItem takes an
alwaysShowRightprop but this right container was only gated toisDesktopso on small viewports, no matter the value ofalwaysShowRightitems were hidden.Then we also fix a little style issue with dark theme, the quick search input had the default browser background.