Conversation
Contributor
Author
|
Howdy @tobiasbrunner, I'm sure you are busy, but would you (or someone) be able to take a look? :-) Please do let me know if there's anything I can help with/do. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
/logoutwas available via GET, which could allow any site to log users out via CSRF (e.g. with animgtag). I made a few updates as part of this:/logoutview to require a POST request. GET/other verbs now return a 405/logoutlogs the user out as expected, GET/logoutjust errors and doesn't destroy the session(also some minor tidying up of the existing code while I was in the
test_viewsfile already)N.B.: I tried updating just the main.scss file and running
dart-sasson it to generate the new css, but the resulting output was very different from the existing main.css - so I just ended up updating that by hand. Running a newer Sass version against it or (possibly) dropping the compiled .css from source control entirely might be things to consider? I am far from a UI expert though, so take those suggestions with a grain of salt, I suppose 🙂