nav-menu: rename side nav references - #6134
Open
wesrupert wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the legacy “side-nav” module/UI to “nav-menu” to align naming with the upcoming top-nav redesign, updating service exports/registration and updating UI + test selectors accordingly.
Changes:
- Renamed React sidebar components to
components-react/nav-menu/*and updated class names/selectors (.side-nav→.nav-menu). - Renamed the service module from
services/side-navtoservices/nav-menu, updated DI usage, and updated app service registry export/imports. - Updated navigation/menu key usage across services, pages, settings UI, and e2e helpers/tests to reference the new
nav-menumodule.
Reviewed changes
Copilot reviewed 36 out of 40 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/regular/streaming/dual-output.ts | Updates UI selector from .side-nav to .nav-menu for Studio Mode click. |
| test/regular/settings/hotkeys.ts | Updates UI selector from .side-nav to .nav-menu for settings navigation. |
| test/regular/obs-importer.ts | Updates UI selector from .side-nav to .nav-menu for settings navigation. |
| test/helpers/modules/settings/settings.ts | Updates helper selector from .side-nav to .nav-menu. |
| test/helpers/modules/navigation.ts | Updates helper selector from .side-nav to .nav-menu. |
| docs/typedoc-monkeypatch.js | Updates wording in comment to “nav menu”. |
| app/services/side-nav/menu-data.ts | Removes old side-nav menu data module. |
| app/services/protocol-links.ts | Switches imports/injection from SideNavService to NavMenuService and updates key usage. |
| app/services/platform-apps/index.ts | Switches injection/usage from SideNavService to NavMenuService for app menu updates. |
| app/services/navigation.ts | Switches injection from SideNavService to NavMenuService and updates navigate() signature. |
| app/services/nav-menu/menu.ts | Introduces NavMenuService implementation (renamed from SideNavService) and updates state shape/nav names. |
| app/services/nav-menu/menu-data.ts | Adds nav-menu key enums/types and menu data builders replacing side-nav menu-data. |
| app/services/nav-menu/index.ts | Adds nav-menu barrel exports. |
| app/services/layout/index.ts | Updates import of menuTitles to new nav-menu path. |
| app/services/highlighter/index.ts | Updates menu key references to ENavMenuKey for navigation/menu selection. |
| app/services/dismissables.ts | Renames dismissable from NewSideNav to NewNavMenu (retains persisted key). |
| app/components/custom-source-properties/PlatformAppProperties.vue.ts | Updates injected service and menu selection call to NavMenuService. |
| app/components-react/windows/settings/Appearance.tsx | Updates to NavMenuService and new key/nav names; updates settings section class naming. |
| app/components-react/windows/settings/Appearance.m.less | Renames .sidenav-settings to .nav-menu-settings. |
| app/components-react/windows/Main.tsx | Switches imported component from SideNav to NavMenu and updates container class name. |
| app/components-react/windows/Main.m.less | Renames .sidenav / .side-nav-container styles to nav-menu equivalents. |
| app/components-react/shared/MenuItem.tsx | Fixes component function name and renames app item style hook for nav-menu. |
| app/components-react/shared/MenuItem.m.less | Renames .app-sidenav-item to .app-nav-menu-item. |
| app/components-react/pages/RecordingHistory.tsx | Updates menu key reference to ENavMenuKey and removes unused SideNavService usage. |
| app/components-react/pages/PlatformAppStore.tsx | Updates menu key reference to nav-menu enum for navigation. |
| app/components-react/pages/layout-editor/TopBar.tsx | Switches SideNavService call to NavMenuService for setting current menu item. |
| app/components-react/pages/AILanding.tsx | Switches SideNavService usage to NavigationService setMenuItem parameter and nav-menu keys. |
| app/components-react/nav-menu/PlatformIndicator.tsx | Adds new nav-menu UI component for platform display in the tools area. |
| app/components-react/nav-menu/PlatformIndicator.m.less | Adds styles for PlatformIndicator. |
| app/components-react/nav-menu/NavTools.tsx | Updates tools menu to use nav-menu service/state + keys; adds PlatformIndicator usage. |
| app/components-react/nav-menu/NavTools.m.less | Adds new styles for NavTools in nav-menu folder. |
| app/components-react/nav-menu/NavMenu.tsx | Renames SideNav component to NavMenu and updates key handling + class names. |
| app/components-react/nav-menu/NavMenu.m.less | Renames side-nav styles to nav-menu style names. |
| app/components-react/nav-menu/FeaturesNav.tsx | Updates feature navigation to NavMenuService, ENavMenuKey, and new nav names. |
| app/components-react/nav-menu/EditorTabs.tsx | Updates editor tabs UI to nav-menu service + styles. |
| app/components-react/nav-menu/AppsNav.tsx | Updates apps nav UI to nav-menu service + keys. |
| app/components-react/index.ts | Updates component registry export from SideNav to NavMenu. |
| app/components-react/hooks/useAgentAppInstalled.ts | Updates navigation to set AppStore menu item via navigate(..., setMenuItem) with nav-menu keys. |
| app/app.g.less | Renames global transition classes from sidenav-slide-* to nav-menu-slide-*. |
| app/app-services.ts | Updates service export/import/registration from SideNavService to NavMenuService. |
Suppressed comments (1)
app/components-react/nav-menu/NavTools.tsx:145
- There is a stray
<></>;expression inside themenuItems.map()callback. This is a no-op and may trigger lint errors (unused expression) or confuse readers.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
BundleMonFiles updated (1)
Unchanged files (3)
Total files change -281B 0% Final result: ✅ View report in BundleMon website ➡️ |
Rename the side-nav module and its files to the nav-menu naming used by the upcoming top-nav redesign, updating every call site. - Rename `components-react/sidebar/` to `components-react/nav-menu/`, including `SideNav.tsx`/`.m.less` to `NavMenu.tsx`/`.m.less` - Rename `services/side-nav` to `services/nav-menu` and update its registration in `app-services.ts` - Update all imports and references across pages, windows, settings, and hooks to the new paths
michelinewu
reviewed
Aug 27, 2026
michelinewu
approved these changes
Aug 27, 2026
wesrupert
force-pushed
the
feat/wr/nav/pr/1
branch
from
August 31, 2026 22:32
1b8a43a to
2283726
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 36 out of 40 changed files in this pull request and generated no new comments.
Suppressed comments (1)
app/components-react/nav-menu/NavTools.tsx:144
- There is an unused JSX fragment expression (
<></>;) inside the DevTools branch. It has no effect and may trigger linting errors (unused expression). Remove it and keep only the return statement.
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
master<-feat/wr/nav/pr/1<-../2<-../3<-../4<-../5Can merge separate from children? No
See PR 5 for screenshots of final product.
Figma: link
Rename the side-nav module and its files to the nav-menu naming used by the upcoming top-nav redesign, updating every call site.
components-react/sidebar/tocomponents-react/nav-menu/, includingSideNav.tsx/.m.lesstoNavMenu.tsx/.m.lessservices/side-navtoservices/nav-menuand update its registration inapp-services.ts