Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
==========================================
+ Coverage 56.40% 57.06% +0.65%
==========================================
Files 45 46 +1
Lines 4480 4565 +85
==========================================
+ Hits 2527 2605 +78
- Misses 1953 1960 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
str4d
force-pushed
the
pq
branch
2 times, most recently
from
July 14, 2026 03:29
a221f3e to
86323d0
Compare
|
Thank you! I've just started using this branch in my project and it's been working great. I noticed rage-keygen still generates X25519 keys. Should it switch to PQ by default or have an option to generate PQ keys? |
Owner
Author
|
Yes, I will be switching the default to PQ in this PR. I have most of the associated changes for that locally; the main thing I'm blocking on for that is the design of the flags (age-keygen went with a -pq flag but that was when it wasn't the default). |
- Non-contributory behaviour in the X25519 component of X-Wing must be rejected. - Errors during `SetupBaseR` must be treated as invalid header errors instead of skipping to the next identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently blocked on RustCrypto/KEMs#369.