Repository navigation
Conversation
aiongg
force-pushed
the
next-pass-records
branch
from
November 14, 2026 01:44
40d9515 to
8d28656
Compare
`Ui::interact_opt` registers the widget as enabled only if both the `Ui` and `InteractOptions::enabled` are. A widget can then draw its own disabled look without a disabled child `Ui`, which would fade its painter, add a node to the accessibility tree and shift the auto-ids of the widgets after it.
Requests focus together with the event filter the widget keeps while focused. `set_focus_lock_filter` only applies once the widget had focus for a pass, so a widget that moves focus to a sibling on an arrow key (a radio group) lost it to egui's directional focus when a second arrow key came in the pass right after the request.
Enter and Space both act as a click on a focused widget. With `activate_on_space: false`, only Enter does, as for a link: Space doesn't activate a link, it scrolls the page in a browser. Defaults to true, which keeps the current behaviour.
…s nest, and a listed layer moves with its whole sublayer tree Popup::show makes its area a sublayer of the layer it opened from when both share an Order (tooltips aside). Areas::end_pass follows each layer with its whole sublayer tree, depth first, and set_layer_order moves a listed layer with all of its unlisted descendants.
…press or click elsewhere
aiongg
force-pushed
the
next-pass-records
branch
from
November 14, 2026 02:00
8d28656 to
689c30e
Compare
Add ScrollArea::horizontal_scroll_bar_label and vertical_scroll_bar_label. The scroll bar AccessKit node had no name, which fails WCAG 4.1.2. The labels are per axis because a name cannot be composed from a shared string in every language, and egui has no built-in UI text.
…t with remove_temp_raw
A part of a pass can be recorded (its shapes, widget rects and AccessKit nodes) and added again in a later pass in place of running it.
aiongg
force-pushed
the
next-pass-records
branch
from
November 14, 2026 02:13
689c30e to
5aa63a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #43 (which builds on #42 and #41); review only the commits after it.
IdTypeMap::insert_temp_boxedkeeps the allocation of a value taken out withremove_temp_raw.Context::ptr_eq.Context::pass_mark,pass_records_sinceandreplay_pass_records: record the shapes, widget rects and AccessKit nodes one part of a pass added, and replay them in a later pass.Behaviour changes
None; all items are new API.
Tests
None of these three commits adds a test.
PATCHES.md: no row.
These commits are on
next, which craft-libsnextpins.