Repository navigation
fix(ci): initialize guide lock in EPUB layer fixture - #2857
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
There was a problem hiding this comment.
AI-generated review (Opus). Not a maintainer decision.
No blocking problems found.
This adds the missing lock_guides field to the hidden-layer Layer literal in the EPUB tests, so the fixture matches the current Layer struct.
- crates/epub/src/tests.rs:1049 sets lock_guides: false. That is the same value serde fills in by default (crates/doc/src/lib.rs:581-582), so the test still checks the same thing.
- The other Layer struct literals (crates/doc/src/build.rs:179, crates/idml/src/import.rs:492, crates/engine/src/cmd/layout/registry.rs:714) already set the field, so no further fixtures need updating.
Claims checked:
- verified: Supplies the new lock_guides field in the EPUB hidden-layer test fixture (crates/epub/src/tests.rs:1049 adds lock_guides: false to the Layer literal; crates/doc/src/lib.rs:582 declares pub lock_guides: bool on Layer, which has no Default derive)
- verified: No production behaviour changes or weakened checks (The only changed file is crates/epub/src/tests.rs, and the value false matches #[serde(default)] at crates/doc/src/lib.rs:581. The test's assertions at crates/epub/src/tests.rs:1053-1054 are unchanged.)
Reviewed at 0d742e0.
Recommendation: merge after CI and checks pass.



Summary
Validation
Summary by CodeRabbit