Skip to content

fix(ci): initialize guide lock in EPUB layer fixture - #2857

Merged
dylanmtaylor merged 1 commit into
mainfrom
fix/epub-layer-guide-default
Nov 16, 2026
Merged

dylanmtaylor merged 1 commit into
mainfrom
fix/epub-layer-guide-default

Conversation

@dylanmtaylor

@dylanmtaylor dylanmtaylor commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Validation

  • Missing-field failure verified in main CI 43776846582 and PR gates.
  • Independent source review and git diff --check passed.
  • Fresh GitHub hosted build/tests required before merge.

Summary by CodeRabbit

  • Tests
    • Updated a test fixture to explicitly set guide locking to disabled.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The EPUB test layer fixture now sets lock_guides to false explicitly.

Changes: EPUB test fixture

Layer / File(s) Summary
Set fixture value
crates/epub/src/tests.rs
The layer fixture now sets lock_guides to false explicitly.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: aiongg, silvertree2010

Merge Risk: Minimal · up to 0d742

This only updates a test fixture to supply a newly required field. It has no production behavior change, and the merge risk is minimal as long as the normal CI build passes.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names a fix in the EPUB test fixture. The change sets the new lock_guides field to false in crates/epub/src/tests.rs, which matches the objective of supplying the field after #1516. The titl…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names a fix in the EPUB test fixture. The change sets the new lock_guides field to false in crates/epub/src/tests.rs, which matches the objective of supplying the field after #1516. The title is specific and accurate, though the fixture scope is named only as the EPUB layer fixture and the 'ci' scope is a slight mismatch because the change touches a test file rather than CI configuration.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Clippy (1.99.1)

Clippy execution timed out

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 278aba4 and 0d742e0.

Files selected for processing: 1

  • crates/epub/src/tests.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@autocraft-bot autocraft-bot Bot added the infra Tests, CI, docs, build, packaging, tooling label Nov 16, 2026
@sonarqubecloud

Copy link
Copy Markdown

@autocraft-bot autocraft-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-generated review (Opus). Not a maintainer decision.

No blocking problems found.

This adds the missing lock_guides field to the hidden-layer Layer literal in the EPUB tests, so the fixture matches the current Layer struct.

  • crates/epub/src/tests.rs:1049 sets lock_guides: false. That is the same value serde fills in by default (crates/doc/src/lib.rs:581-582), so the test still checks the same thing.
  • The other Layer struct literals (crates/doc/src/build.rs:179, crates/idml/src/import.rs:492, crates/engine/src/cmd/layout/registry.rs:714) already set the field, so no further fixtures need updating.

Claims checked:

  • verified: Supplies the new lock_guides field in the EPUB hidden-layer test fixture (crates/epub/src/tests.rs:1049 adds lock_guides: false to the Layer literal; crates/doc/src/lib.rs:582 declares pub lock_guides: bool on Layer, which has no Default derive)
  • verified: No production behaviour changes or weakened checks (The only changed file is crates/epub/src/tests.rs, and the value false matches #[serde(default)] at crates/doc/src/lib.rs:581. The test's assertions at crates/epub/src/tests.rs:1053-1054 are unchanged.)

Reviewed at 0d742e0.

Recommendation: merge after CI and checks pass.

@dylanmtaylor
dylanmtaylor merged commit 11ad84f into main Nov 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Tests, CI, docs, build, packaging, tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant