Skip to content

feat(i18n): initial Hebrew interface locale and RTL UI support (#2468) - #2670

Draft
nocturney wants to merge 40 commits into
storytold:mainfrom
nocturney:feat/hebrew-ui-initial-20261112-qw
Draft

nocturney wants to merge 40 commits into
storytold:mainfrom
nocturney:feat/hebrew-ui-initial-20261112-qw

Conversation

@nocturney

@nocturney nocturney commented Nov 12, 2026 •

Copy link
Copy Markdown

Refs #2468 (partial contribution only; does not close the full-Hebrew request).

What changed

  • Add he / עברית to the existing DesignCraft interface-language picker.
  • Reuse DesignCraft's existing UI RTL path (is_rtl), alongside Arabic. Document/story direction and user-written content are untouched.
  • Add an initial clean-room catalog, now expanded to 1508 Hebrew interface strings under crates/ui-egui/src/i18n/he.rs: core menus, File/Open/Save/Print, layout and paragraph-style controls, accessible Arrangement, package/export/print and common panels.
  • Use source-English keys that already exist in DesignCraft's own source inventory. The original English label remains the fallback where Hebrew has not yet been added.
  • Add a focused Rust regression for language-picker registration, RTL state, catalog uniqueness, source-key presence, placeholder/ellipsis parity, actual Hebrew lookups and fallback. Include Hebrew in the existing per-language lookup matrix.

Checks (exact source)

Base storytold/designcraft main 6fff5328eb59a5fdff5d91df44034212cc07e670.

  • Independent Python audit: 119 / 119 keys matched to existing application source strings, no duplicates or missing entries, original Hebrew text, NFC normalization, placeholders/ellipsis/colon checks.
  • rustfmt 1.10.0 --edition 2024 --check against exact source bytes on MacMiniOffice2, with the repository's rustfmt.toml; SHA-256 compared byte-for-byte with the pushed files.
  • git diff --check and fork branch readback.
  • Lightweight standalone compiled Rust source test of exact new he.rs bytes: rustc --edition=2024 --test on MacMiniOffice2, 2 passed / 0 failed. Covers 119 Hebrew key/value pairs, uniqueness, placeholders, and common lookup entries; source SHA256 e247fc3b38d1f780dc7a0b9b55802fc11b8795937f634ba8e4bdda4b34bd37ef cross-checked with committed source.
  • Compiled and executed the actual i18n.rs implementation at exact GitHub commit c8a03c5 in a standalone rustc --edition=2024 smoke harness: picker recognizes he / עברית, is_rtl("he"), Hebrew File/Save As/Arrangement lookups, English fallback, Arabic unchanged. Passed and read exact source blob IDs (56990ae, 7a7e625); only three unused document-style constants were stubbed to avoid compiling the unrelated designcraft_doc crate.
  • Integrated DesignCraft Cargo UI unit test and full cargo xtask ci have not yet run; standalone compiled-source smoke is not a native app or visual rendering test.
  • Real Hebrew glyph rendering, native UI screenshot, Windows portable release and save/reopen were not verified.
  • Full cargo xtask ci, WASM, font-bundle QA and maintainer review remain outstanding.

Limits and review guidance

This is a small, useful first increment, not a statement of full right-to-left parity or release readiness. Other menu/dialog labels still fall back to English. Existing interface RTL positioning is reused; mixed Hebrew/English labels, keyboard shortcuts, font fallback, clipping and document-direction controls need native visual QA before readiness or merge. No new font files, external dependencies, release binaries or user-document changes are included.

Please review the initial terminology and glyph handling. Keep as draft until targeted tests and native UX review are complete.

2026-11-12 round 4 quick wins: Typography, pages and panels

  • Commit 2ed9757b0426a97ab8c362591c06c8f5eccfd47f added 107 clean-room Hebrew source-linked UI strings, extending the earlier 119 to 226 original interface labels. New coverage includes paragraph/character formatting, hyphenation, list numbering, baseline grid, page/panel arrangements and Flex layout commands. Prior 119 labels unchanged.
  • Exact GitHub he.rs blob 8872b150112f8e0ec89192b45a6e01406800ead9, Rust regression source tests.rs blob 73e6893cea2779d401da080d692bde666668a400 read back. Every new English key exists in the original DesignCraft source catalog; UTF-8 NFC, key uniqueness, placeholders/ellipsis/colon parity, git diff --check PASS.
  • rustfmt --edition 2024 --check PASS against exact task-owned files on MacMiniOffice2, SHA256 cross-read with Windows. A focused standalone rustc --edition=2024 --test compilation of the exact updated he.rs source passed 2/2 tests, with all 226 labels, uniqueness, placeholders and key UI terms checked; no integrated UI runtime/Cargo test or native screenshot claimed for this commit.
  • Keep partial Hebrew locale DRAFT pending full font/RTL/visual QA, complete tests and maintainer review; not a full Feature request: full Hebrew UI (he) with RTL support #2468 implementation.

Quick Wins round 5 — 12 November 2026

  • Commit d67a266: 270 new clean-room Hebrew source-linked UI strings for page navigation, objects, tables, paragraph and character styles, document setup, new-document/start screens, colour and effect controls. Only crates/ui-egui/src/i18n/he.rs and corresponding i18n/tests.rs count/key assertions changed.
  • GitHub source blob 425c55c8f54d724ff17475c1314790bff349981a: 496 unique keys, original 226 preserved unchanged; 270 new keys match the actual upstream English UI source inventory. Python audit checks placeholders/ellipsis/period/colon, whitespace, NFC, uniqueness, UTF-8 and git diff --check: PASS. Exact cross-machine SHA256 bc32cb1bb9fe7c28e0b62e83fe798faa8f21d89dbdeec702b26f5a6763e5cbdf; repository-configured rustfmt 1.10.0 --check PASS.
  • rustc --edition 2024 --test compiled the actual updated he.rs and ran 2 focused catalog tests PASS/0 FAIL for 496 records and representative source terms. Integrated Cargo, native GUI screenshot, RTL/glyph review and save/reopen were not run on this head. This remains a DRAFT, unmerged, not full Feature request: full Hebrew UI (he) with RTL support #2468 implementation.

Quick Wins round 6 — 12 November 2026

  • Commit 36cf847 added 206 new original Hebrew UI translations for PDF/IDML/EPUB export, preflight, missing glyph/fallback font warnings, recovery, page navigation and paragraph/table styles. Exactly two unchanged standard identifiers PDF/X-4 / PDF/A-2b were excluded from translation, not counted. Only crates/ui-egui/src/i18n/he.rs and i18n/tests.rs changed.
  • Exact source catalog GitHub blob 842da0eaf596ef08d49290b93f07aefabe844c8d: 702 unique Hebrew entries, previous 496 preserved; English keys verified against source-matched i18n/ar.rs inventory. UTF-8 NFC, duplicate/placeholder/colon/period/ellipsis/whitespace consistency, git diff --check: PASS. Source-cross-machine SHA256 d1917859651e96ffa00ae49d928a2c512718ecb5ec779d693af201c91c0e6c0c, exact tests.rs 37eaa07cdc96c3b4e9ef42dcf961213a413fa595191e0c8908a32db9d9adddb0.
  • MacMiniOffice2: repository-configured Rustfmt PASS, standalone rustc --edition 2024 --test on exact new he.rs 2/2 PASS (702 entries, real UI key lookups, placeholders). Tracked DesignCraft tests updated to new count and seven representative key lookups. No integrated full Cargo/GUI screenshot, glyph/RTL or save/reopen test on this head. Partial, draft, unmerged and does not close Feature request: full Hebrew UI (he) with RTL support #2468.

Quick Wins round 7 — 12 November 2026

  • Commit e134eee adds 185 original Hebrew source-linked UI labels for paragraph typography, table rows/columns and selection, footnotes, alignment, layers, guides, notes and document layout. Only crates/ui-egui/src/i18n/he.rs and i18n/tests.rs changed; 8 native lookup assertions and regression table count updated.
  • Exact latest GitHub catalog blob 0b34076694d430ce0c26eb94ee1089f34e95574d: 887 distinct source-matched Hebrew UI keys, all 702 prior pairs unchanged. All new English keys confirmed in original DesignCraft ar.rs source English inventory. UTF-8 NFC, unique/nonempty source terms, placeholder/ellipsis/period/colon/whitespace parity, git diff --check: PASS. Cross-host SHA256 of exact source he.rs 2cf99d69deda612273d994878c58d6a2d0729eecdbdbaab6c7122b13c84ce444, regression tests.rs 5ed92eab2f561899a84e2109f8755dc5fa6bfd5aedb19e42b5aaf89f3ac8e4be.
  • MacMiniOffice2 repo-configured rustfmt --check PASS, independent compiled rustc --edition 2024 --test on exact updated he.rs 2/2 PASS (887 source keys, placeholders and 10 common UI lookups). Full integrated Cargo/GUI screenshot, latest native save/reopen and RTL/font acceptance were not run. DRAFT unmerged, Feature request: full Hebrew UI (he) with RTL support #2468 partial.

Quick Wins round 8 — 12 November 2026

  • Commit 5665859 adds 145 original Hebrew UI labels for document/book and workspace creation, empty/error states, hyperlinks, footnotes/endnotes, XML import, notes, forms and print/export controls. Untranslated standard technical name OpenType intentionally left intact and not counted. Only crates/ui-egui/src/i18n/he.rs and i18n/tests.rs changed.
  • Latest exact GitHub catalog blob 35d67849df952e7b91e40b9b5d91d2c269481be6: 1032 unique original source-key Hebrew labels, all 887 prior pairs preserved. Source English key inventory from i18n/ar.rs, duplicate/nonempty, UTF-8 NFC, placeholders, punctuation and technical identifiers, git diff --check: PASS. Checked-in tests table count and nine actual source lookups updated.
  • On MacMiniOffice2, repository-configured Rustfmt PASS; standalone rustc --edition 2024 --test compiled exact updated he.rs 2/2 PASS, verifying 1032 unique source keys, placeholders/punctuation and actual UI lookups. Cross-host SHA256 he.rs 1e0ddbf58c3f92d40a9b49c224e173e4dde1aa5058481593d8dcacb3bd2b5bfb, tests.rs fd5895781efd1c12e52c38344376b12180c40e36a107bbf87a51c0deb3e99ae1. No full integrated Cargo or native GUI/RTL/glyph/save-reopen test on newest head. DRAFT unmerged; partial Feature request: full Hebrew UI (he) with RTL support #2468.

Quick Wins round 9 — 12 November 2026

  • Commit 8ef17c2 adds 185 clean-room source-linked native Hebrew labels for paragraph formatting, hyphenation, variable fonts, text/table conversion, document page masters/parents, liquid layouts, smart guides, frame fitting, column/margin controls, swatches/gradient options and layout colors. Only crates/ui-egui/src/i18n/he.rs + focused i18n/tests.rs changed.
  • Exact GitHub he.rs blob eb58f5f55ab40f6e6b4119dd95e9d032f5b8e1e1: 1217 unique original source English-key Hebrew UI translations, all earlier 1032 pairs unchanged. All 185 newly translated English keys verified against native DesignCraft i18n/ar.rs source-English inventory; UTF-8 NFC, duplicate/nonempty, placeholder/period/ellipsis/colon and technical formatting parity, git diff --check: PASS.
  • Updated in-tree regression to 1217 entries and 10 additional actual native UI-key assertions. MacMiniOffice2 repository-configured rustfmt --edition 2024 --check PASS; standalone compiled rustc --edition 2024 --test with exact updated he.rs: 2/2 PASS (1217 unique records, placeholder/punctuation, real font/layout/guide/parent/lookups and fallback). Cross-machine SHA256 he.rs de77f4dd94dbb03a78224e36e42b26a0cd940d90c7fc9be03e295a295271307e, tests.rs 2082a4db587b20a9d34ff50ca659f836b949afcaea99ba405cc94821b8d49270. Integrated Cargo, current GUI font/RTL/visual save/reopen not run. DRAFT unmerged, still partial Feature request: full Hebrew UI (he) with RTL support #2468.

Quick Wins round 10 — 12 November 2026

  • Commit 3541ee7 adds 61 clean-room, source-matched Hebrew native UI labels for Object/Type/Edit/View/Window menu paths, object fitting and transforms, special character insertion, hyperlinks, tracking changes, text on path, proofing, document footnote options and color-blindness settings. Only crates/ui-egui/src/i18n/he.rs and i18n/tests.rs modified.
  • Exact GitHub locale blob c838fa0c613366f0f66e76210a4740e834b3a9a2: 1,278 unique source-key translations, all 1,217 prior source/values unchanged. All 61 English source keys confirmed in native i18n/ar.rs 2,152-row English inventory; UTF-8 NFC, duplicates/nonempty, placeholders, trailing punctuation and slash-separated menu nesting for the newly added path strings; git diff --check: PASS.
  • Existing tracked Rust regression table count changed to 1278, plus 12 exact new menu/control lookups. MacMiniOffice2 repository-configured Rustfmt PASS, standalone rustc --edition 2024 --test compiling exact updated he.rs: 2/2 PASS (1,278 unique entries, placeholders/end punctuation, 12 native menu lookups with path-depth checks and fallback). Existing older translations with different slash conventions intentionally remain unchanged; menu-depth assertion is scoped to new strings only. Cross-machine SHA256 he.rs cb17f8e6ac90b8fc74aaca5aad27cad41dd8ae2b6b28abbc0d1c8f4b234df76a, tests.rs d473606f6ec1194d3508fb94c31c3d644638269eadf4b6ef47c62e6aac5fc60a.
  • Full integrated Cargo/Native GUI/RTL/glyph/visual save-reopen not run. Existing partial upstream PR stays OPEN DRAFT/unmerged.

Hebrew DesignCraft Quick Wins — parallel round 4 (2026-11-12)

30 previously untranslated, original English-source-matched Hebrew Native UI labels added in three independent focused commits:

  • 10 document, placement, link and library workflow labels (c799e3a).
  • 10 typography, superscript, underline, footnote and hyperlink labels (87e955d).
  • 10 visual effects, drop shadow, table fill, alignment and fill/stroke labels (bee8b82).
  • Focused Rust regression source formatting follow-up a452ca2.

Source scope ONLY crates/ui-egui/src/i18n/he.rs and crates/ui-egui/src/i18n/tests.rs. Prior 1,278 Hebrew source keys and original values preserved; current catalog 1,308 source-linked entries; the existing table-size assertion has been updated. All 30 keys verified against exact English keys in ar.rs and actual Rust UI production literals. Strict unique-key, NFC/UTF-8, placeholder, ellipsis/colon/period and scoped git diff QA passed. Three source regression functions were checked in.

Executable QA: macOS rustc 1.99.1 compiled the actual he.rs source from exact PR HEAD, loaded 1,308 rows and verified 30/30 exact new Hebrew lookups; focused new Rust regression blocks passed rustfmt --check (edition 2024). Full-file rustfmt still reports unrelated pre-existing formatting in both Rust files; unchanged old source was deliberately not reformatted. NOT CLAIMED: full integrated Cargo test, native Hebrew GUI/RTL screenshot, save/reopen, CI pass, maintainer merge, release or installer change. Remains OPEN/DRAFT.

2026-11-16 NIGHT-05 source-test repair

  • Commit 2ff443b fixes a stale catalog count (1,325 expected vs 1,413 actual) and invalid dependence on the incomplete Arabic translation catalog (65 source-backed Hebrew UI entries are absent in Arabic). Previous suggestions were not re-added.
  • Four focused native-label regression assertions added. Only the test source changed; all 1,413 Hebrew catalog entries remain unchanged. Static audit: no duplicate keys, mismatched placeholders/punctuation, non-NFC strings or bidi override/isolate characters.
  • Integrated Cargo tests and Native Hebrew GUI / RTL / glyph QA not run at this commit; CI not green, approval gate. DRAFT until integrated tests, visual/native review and maintainer decision.

2026-11-16 NIGHT-05: 31 original English-source Hebrew labels

  • Commits dbbf2122ac154a0a765d1959cbf061f195dd4a1d (31 new original Hebrew UI/typography/search labels) and a0081358b583c47d1133cc700304f5df8986ce5d (catalog count and 31 English-source / actual lookup regression fixtures); 1477 older entries preserved. The prior 90 merged proposals are NOT recounted.

  • Original English IDs come strictly from storytold/designcraft main crates/ui-egui/src/i18n/fr.rs first/English key column, blob 8a7c537ceae99da29c0563f40548e6be8d6cd43d; no translated French values, proprietary language assets or fonts copied.

  • Verified exact original upstream PR head a0081358b583c47d1133cc700304f5df8986ce5d, HE blob ab7f1c5c20a6c357385cf507ce2f648c71e00ddc, tests blob 471d31088c8aa49f79b6962da202b3d709928491; static checks: unique new keys, English-source membership 31/31, Unicode NFC, placeholder/colon/ellipsis parity and no unsafe bidi control characters.

  • CI: CI and SonarCloud both completed action_required, NOT green; upstream fork-workflow approval is pending. New Rust test is committed; integrated Cargo test not yet claimed passed at this edit. Native Hebrew/RTL visual screenshot, save/reopen, maintainer approval, upstream merge/release still outstanding. Keep PR DRAFT.

  • Compiled standalone Rust source checks on exact final HEAD f1d5020 PASSED 2/2 (Hebrew 1508 unique table keys and all 31 new English-key/lookup fixtures). These are NOT integrated DesignCraft Cargo tests.

  • Initial 32-label draft exposed one duplicate existing multiline Hebrew entry; fixed by commits 3ab418c (removes duplicate) and f1d5020 (regression count/fixture correction). All 1477 pre-existing entries remain. Final exact HE blob 562861ac9c5c434166a36ecda0077f83449a86e7; tests blob a9634ae9f65ca4a6abaaf8bb83a1cb17d648e514.

  • Attempted full integrated Cargo UI test on permitted Windows Chris machine; FAILED before running tests due third-party aws-lc-sys v0.46.0 native C build missing jitterentropy.h and compiler errors. Log in isolated NIGHT-05 receipt; no Cargo pass claim. Final exact-head CI and SonarCloud are action_required, NOT GREEN. Native RTL screenshot/save-reopen and maintainer approval remain unverified.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@autocraft-bot autocraft-bot Bot added the missing feature The reference application has it and we do not, or only part of it label Nov 12, 2026
@autocraft-bot autocraft-bot Bot added the needs decision Needs a product or scope decision by a maintainer label Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing feature The reference application has it and we do not, or only part of it needs decision Needs a product or scope decision by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: full Hebrew UI (he) with RTL support

1 participant