Repository navigation
SpaceMouse: calibrate devices that are silent at rest, fix the pan Y direction, zoom on push/pull only - #983
Open
alexanderalber wants to merge 3 commits into
Open
alexanderalber wants to merge 3 commits into
alexanderalber wants to merge 3 commits into
Conversation
…m on push/pull only Tested on a SpaceNavigator (046d:c626, Windows 11, no 3DxWare). It sends no reports while the cap rests, so the rest calibration from storytold#650 waited for resting samples that never came and finished only by chance. 300 ms without an axis report now counts as rest at zero; devices that stream at rest keep the window calibration. Also from the device test: pan Y was inverted (HID +Y points towards the user), twist no longer zooms, the 3D Mouse dialog no longer blocks the device it configures, and the default pan sensitivity goes from 0.8 to 1.2. gaps.md H1 and hardware-parity.md record what storytold#650 covers. generated with Claude Code
Tried both directions on a SpaceNavigator; this one is clearly the more natural. "Reverse zoom direction" still flips it. generated with Claude Code
generated with Claude Code
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #650, tested on real hardware (#623): classic SpaceNavigator 046d:c626, Windows 11, no 3DxWare.
Calibration never finished on a device that is silent at rest. The SpaceNavigator sends no reports while the cap rests. Measured over 40 s:
[0 ×17, 38, 125 ×8, 16, 0 ×14]reports per second, all axes exactly 0 when it starts again. The rest calibration waits for 16 resting samples in 400 ms, so it finished only by chance, from a light touch, and used that touch as the bias. Now 300 ms without an axis report counts as rest at zero (Filter::quiet). Devices that stream at rest still calibrate through the existing window. My original measurement in #623 claimed the device streams at rest, which was wrong. Sorry.Other fixes from the device test:
contributors/people.toml: my own entry (real name), as AGENTS.md describes.docs/hardware-parity.mdanddocs/gaps.mdH1: what Add raw-HID SpaceMouse 2D navigation #650 covers and what is left (macOS, web, orbit, 3DxWare coexistence). These rows overlap with the open audit PR docs: re-audit gaps.md and parity docs against main #819, which notes Add raw-HID SpaceMouse 2D navigation #650 as untested on a device; whichever merges second has a small conflict there, and this PR has the tested state.Tests:
spacemouse::motion::tests(silent calibration, reports postponing it, pan directions, twist not zooming, hostile reports).cargo xtask cipasses. Checked on the device: works right after start and after the calibrate button, pan in both directions, zoom in both directions, twist ignored, navigation with the 3D Mouse dialog open.🤖 Generated with Claude Code