Added remaining F2008 intrinsics - #518
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
=======================================
Coverage 92.25% 92.26%
=======================================
Files 89 89
Lines 13926 13940 +14
=======================================
+ Hits 12848 12862 +14
Misses 1078 1078 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
@sergisiso @arporter Ready for a look. |
arporter
requested changes
Jul 24, 2026
arporter
left a comment
arporter
left a comment
Member
There was a problem hiding this comment.
Good job Aidan, thanks for tackling this. I attempted to be thorough and think I found two mistakes.
We also need some tests... :-)
arporter
added
reviewed with actions
Open
LonelyCat124
added
ready for review
and removed
reviewed with actions
Author
|
@arporter Ready for another look. |
Member
|
All looking good. I'm testing this branch with PSyclone in stfc/PSyclone#3571. If all is well I'll proceed to merge. |
arporter
approved these changes
Aug 26, 2026
arporter
left a comment
arporter
left a comment
Member
There was a problem hiding this comment.
PSyclone ITs were all green with this branch.
Will proceed to merge.
arporter
added
ready for merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds all the new F2008 intrinsics. There are some potential extensions to previously existing intrinsics I didn't include, but I wasn't certain enough of those to add them in this PR.
All intrinsics taken from https://wg5-fortran.org/N1851-N1900/N1891.pdf and checked with gcc docs if I was unsure about arguments.