WIP: rework accounting scripts - #288
Draft
anish-mudaraddi wants to merge 4 commits into
Draft
Conversation
gmatthews20
requested changes
Aug 25, 2026
gmatthews20
left a comment
Contributor
There was a problem hiding this comment.
I haven't yet reviewed any of the tests. Will take a look once we're happy with the functionality
Comment on lines
+1
to
+2
| # Use Python 3.12 slim image as base | ||
| FROM python:3.12-slim |
Contributor
There was a problem hiding this comment.
Why was version 3.12 chosen, any reason we couldn't use something newer like 3.14?
Collaborator
Author
There was a problem hiding this comment.
I used python3.12 to write the code - hence python:3.12
gmatthews20
requested changes
Aug 26, 2026
anish-mudaraddi
force-pushed
the
wip-accounting
branch
2 times, most recently
from
August 28, 2026 14:20
93a8215 to
817a236
Compare
anish-mudaraddi
force-pushed
the
wip-accounting
branch
from
August 28, 2026 14:27
817a236 to
b289baa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make accounting scripts run as a docker container
requirements:
the docker container must run continuously - to get accounting data every interval
also, the container can be used to collect past accounting data by providing timestamps from the past.
there should be good logs so it can run on kayobe and be debugged easily
there should be a dry-run feature - so we can test improvements in the future without sending data anywhere
there should be good testing and linting to keep up with our coding standards
it should work on a supported python version and the dependencies should be up-to-date
Still TODO:
so that we can auto-build and version the docker container