(Closes #3568) Removes references to fparser directly in the DUCs - #3574
Open
LonelyCat124 wants to merge 4 commits into
Open
(Closes #3568) Removes references to fparser directly in the DUCs#3574LonelyCat124 wants to merge 4 commits into
LonelyCat124 wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3574 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 399 399
Lines 56181 56227 +46
=========================================
+ Hits 56181 56227 +46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
A related method to add here would be It also might be useful to have a method |
Collaborator
Author
|
I'll add those as well. |
Collaborator
Author
|
Added @mn416 's suggestions (I think), so ready for review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided this was a small change and better to do now, and the TreeSitter changes can come later.
The only things I'm unsure about are why the base CodeBlock class isn't abstract now, and whether its correct to do
-> boolon an abstractmethod with no code? It conceptually seems correct but I'm not sure about the reality.Assuming coverage is correct this is ready for a review from @arporter @sergisiso