[XLA] Preserve feed tensor shapes on graph arguments - #60
Open
stevenvar wants to merge 1 commit into
Open
Conversation
Copy the selected feed tensor shape to replacement _Arg nodes and avoid inventing rank-one shapes when argument metadata is unavailable.
stevenvar
force-pushed
the
steven.preserve-feed-output-shapes
branch
from
September 8, 2026 15:45
175903e to
df4dab8
Compare
stevenvar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a feed tensor is replaced by an
_Argnode, losing its shape can leave GraphProperties with incorrect rank information and change XLA clustering. A feed shaped[-1, 224, 224, 3]should keep that shape on the replacement argument.This change copies the shape of the selected output to its replacement
_Arg, using a placeholder'sshapeattribute when_output_shapesis unavailable. If no shape is available, GraphProperties keeps the rank unknown instead of inventing a rank-one shape.Tests
SubgraphTest.FedPlaceholderPreservesShape_FunctionConventionchecks that replacing a placeholder with an_Argpreserves all four dimensions of[-1, 224, 224, 3].