main: add sinkhole-ip net-conn bug fix and enabled setting to protect agent from getting killed#483
Merged
Conversation
generation of dummyNetworkEvent incase a domain was blocked. enabled setting to protect agent from getting killed
h0x0er
changed the title
h0x0er
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adjusts network telemetry reporting to avoid emitting net-connection events for the DNS sinkhole IP (preventing downstream issues when domains are blocked) and adds a global feature-flag-controlled switch to disable kill enforcement in Armour to prevent the agent from being terminated unexpectedly.
Changes:
- Skip
sendNetConnection+ related logging/annotation forStepSecuritySinkHoleIPAddressin the network monitor drop path. - Add
disable_kill_enforcementto global feature flags and wire it into Armour configuration (EnforceKillBlock). - Fetch global feature flags once during agent startup for use in kill enforcement configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| netmon.go | Avoids net-connection telemetry/logging/annotation for sinkhole IP drops. |
| global_feature_flags.go | Adds a new global feature flag field to control kill enforcement. |
| agent.go | Uses global flag to configure Armour EnforceKillBlock. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ashishkurmi
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
don't net-conn event for sinkhole-ip as this was causing issue in generation of dummyNetworkEvent incase a domain was blocked.
enabled setting to protect agent from getting killed