📝 Inline fix most egregious typos - #1984
Open
JFWooten4 wants to merge 2 commits into
Open
Conversation
This looks super wierd with double backticks enclosing almost two sentences worth of text.
Presumably we cannot do an incorrect snapshot the wrong way as a double negative
|
|
||
| If the entry is amendable, then a new ledger entry with value ``correct_entry` - base64 encoded `LedgerEntry` XDR, the correct value that should have been archived (i.e. the value of the affected entry at the moment when it has been archived) | ||
| ` (from the table) will be written to the Hot Archive and thus become the most recent state of the entry that will be used for the restoration. | ||
| If the entry is amendable, then a new ledger entry with value `correct_entry` (defined above) from the table will be written to the Hot Archive and thus become the most recent state of the entry that will be used for the restoration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks the first two commits made in #1803 just four days after the CAP-76 draft proposal was released. In deference to #1913 (comment) precedence for not updating after Final status, it can be added using a merge commit with the original commit metadata. This places the updates a full four days before the last adopting commit.
I worked well into the night to get this in as soon as possible after the bug. Even though I don't think all of it will get merged in, I really think we should do this minimum set of changes. c96ca2a can be brought up separately if the maintainers want to keep that style uniform downstream.