Fix event-testing assertion in events example to use ContractEvents - #2687
Open
leighmcculloch wants to merge 1 commit into
Open
Fix event-testing assertion in events example to use ContractEvents#2687leighmcculloch wants to merge 1 commit into
leighmcculloch wants to merge 1 commit into
Conversation
### What Update the test's event assertions to use the SDK's current event-testing APIs (XDR comparison via `to_xdr`, `filter_by_contract`), and point the example link at the current version. ### Why The old tuple-vec comparison no longer type-checks against the current SDK, so the example as shown would fail to compile.
leighmcculloch
requested review from
ElliotFriend,
briwylde08,
Copilot and
mootz12
July 26, 2026 23:58
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the events example to match the current Soroban SDK event-testing APIs and upstream example.
Changes:
- Uses XDR-based
ContractEventsassertions and contract filtering. - Updates links and cloning instructions to
main. - Documents the supported event comparison approaches.
Recommendation: MERGE-READY — correct and complete.
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update the test's event assertions to use the SDK's current event-testing APIs (XDR comparison via
to_xdr,filter_by_contract), and point the example link at the current version.Why
The old tuple-vec comparison no longer type-checks against the current SDK, so the example as shown would fail to compile.