Fix indexer demo DOM XSS - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Hardens the indexer demo against DOM XSS from untrusted metadata.
Changes:
- Escapes dynamic HTML text and attribute values.
- Adds CSP protection and escape regression tests.
- Adds demo test/build coverage to CI.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
indexer/demo/src/main.ts |
Escapes indexer metadata before rendering. |
indexer/demo/src/html.ts |
Adds HTML escaping utility. |
indexer/demo/src/html.test.ts |
Tests escaping behavior and payloads. |
indexer/demo/index.html |
Adds Content Security Policy. |
indexer/demo/package.json |
Adds Vitest and test script. |
pnpm-lock.yaml |
Locks the Vitest dependency. |
.github/workflows/ci.yml |
Runs indexer demo tests and build. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification