Repository navigation
Conversation
ubuntu-latest now resolves to ubuntu-26.04, where 'npx playwright install --with-deps' (Playwright 1.49) fails before any test runs: it installs the Ubuntu 24.04 package set (libicu74, libvpx9, libx264-164, libxml2), which is not available on 26.04.
Code Review✅ Passed Reviewed |
PR Readiness Review✅ Passed Reviewed |
Contributor
Author
|
E2E validation result for this PR: run https://github.com/startreedata/thirdeye/actions/runs/41407038977 (runner image What this change fixes (verified):
What is still failing (not caused or fixed by this PR): 27 failed, 1 passed, 3 skipped, 7 did not run (32.6 min).
So this PR is the necessary runner fix, but on its own it does not make E2E green. Returning it to draft. Next step for repository owners: confirm or refresh the E2E backend and token behind those secrets, then re-run. No tests were disabled or changed. |
xiangfu0
marked this pull request as draft
November 2, 2026 08:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
TE UI - E2E Testsfails on every non-draft PR before any test runs, whatever the change. For example, #1818 and #1820 only touchpom.xml, and this job sparse-checks-out onlythirdeye-ui/.Description
.github/workflows/fe-e2e.yaml:runs-on: ubuntu-latest→runs-on: ubuntu-24.04(one line). No test, dependency or frontend changes.Evidence from job 125148282103 (#1818) and run 41406063517 (#1820), both identical:
Image: ubuntu-26.04:ubuntu-latestnow lands on the 26.04 image.Install Playwright Browsersstep (npx playwright install --with-deps,@playwright/test ^1.49.1) fails with:E: Package 'libicu74' has no installation candidate,E: Unable to locate package libvpx9,E: Package 'libxml2' has no installation candidate,E: Unable to locate package libx264-164, thenFailed to install browsers. Those are Ubuntu 24.04 package names, which this Playwright version installs.Run local serverandRun Playwright testsare then skipped.ubuntu-24.04is a supported GitHub-hosted runner label (actions/runner-images README).Not changed:
gyp ERR! ... ValueError: invalid mode: 'rU'duringnpm ci. Node 14's bundled node-gyp 5.1.1 cannot run on Python ≥ 3.11, but the optional native builds that fail are non-fatal:Install dependenciessucceeds (2,689 packages). Fixing that means a Node/toolchain upgrade, a separate frontend change.How to test
This PR's own
TE UI - E2E Testsrun is the validation: the Playwright browser install should succeed on 24.04 and the existing E2E suite should run against the configured E2E backend (secretsE2E_TOKEN/E2E_PROXY). Results will be reported in a comment.Run backend testson this PR fails at Testcontainers Docker discovery until #1820 is merged; that is unrelated.