Skip to content

[DO NOT MERGE] CI validation: #1819 + #1820 - #1822

Closed
xiangfu0 wants to merge 8 commits into
masterfrom
cs_gjy7snIsW9/ci-validate/datasource-pinot-client-with-1820
Closed

xiangfu0 wants to merge 8 commits into
masterfrom
cs_gjy7snIsW9/ci-validate/datasource-pinot-client-with-1820

Conversation

@xiangfu0

@xiangfu0 xiangfu0 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

CI validation only — do not merge, do not review. Will be closed once CI reports.

Head = #1819 (unchanged) merged with #1820 (testcontainers 1.21.4), so Run backend tests can get past Docker discovery and run the full build, including real Pinot/MySQL integration tests, for #1819. The source PRs #1819 and #1820 stay independent.

…http-client 3.0.14, libthrift 0.25.0, httpcore5 5.4.4

Fixes Snyk SNYK-JAVA-ORGASYNCHTTPCLIENT-20571297 (CVE-2026-107228),
-20571429 (CVE-2026-107230), -20571670 (CVE-2026-107282),
SNYK-JAVA-ORGAPACHETHRIFT-20417181, -20824690, -20824701, -21279781 and
SNYK-JAVA-ORGAPACHEHTTPCOMPONENTSCORE5-17817218 (CVE-2026-54399) in the
datasource-pinot plugin archive.

- pinot-java-client / pinot-spi 1.2.0 -> 1.6.0: async-http-client 3.x is not
  compatible with pinot-java-client 1.2.0, and the 2.x line has no fix
- async-http-client 3.0.14 with netty-bom 4.2.18.Final, the netty line it is
  built on. Replaces the netty 4.1.60 / tcnative 2.0.61 jars previously
  resolved through async-http-client 2.12.3
- libthrift 0.25.0
- httpclient5 5.6.5 / httpcore5 + httpcore5-h2 5.4.4 managed: libthrift
  declares httpcore5 5.2 and would otherwise win dependency mediation
- httpmime is declared explicitly: used by PinotControllerRestClient and no
  longer brought transitively
- nimbus-jose-jwt excluded from pinot-java-client: only used by pinot
  server-side audit, and it would be downgraded to the version managed in
  the root pom
….6.0

pinot-java-client 1.6.0 builds broker SSLEngines directly from the provided
SSLContext (DefaultSslContextProvider) without setting the HTTPS endpoint
identification algorithm, and async-http-client 3.x no longer sets it on
engines from a custom SslEngineFactory. With 1.2.0 the context was wrapped in
a netty JdkSslContext and async-http-client 2.x enabled it.

Wrap the context passed to the Pinot client so every engine verifies the
broker hostname. Also clarify that the httpclient5/httpcore5 pins apply to
the server modules (calcite/avatica) too.
…ility

testcontainers 1.19.3 talks to the Docker daemon with API version 1.32.
Docker Engine 29 (GitHub ubuntu-latest runners) rejects it: "client version
1.32 is too old. Minimum supported API version is 1.40", so every
Testcontainers-based test fails with "Could not find a valid Docker
environment". 1.21.4 negotiates a supported API version.
…lugin

The root-level pin also upgraded the dropwizard-client used by the
integration tests (httpclient5 5.4.1 -> 5.6.5), which then failed to read
gzip-encoded responses ("Not in GZIP format"). The reported httpcore5 finding
is in the datasource-pinot archive only, so pin it there; other modules keep
the versions brought by dropwizard-client and calcite (avatica).
… an SSL context

- fail instead of continuing when the default SSL context is unavailable:
  the pinot client would otherwise build its own context without broker
  hostname verification
- default/supported SSLParameters also carry the HTTPS endpoint
  identification algorithm; the wrapper cannot be re-initialized
- httpclient5/httpcore5 plugin pins use properties

xiangfu0 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Validation complete: #1819 head 0d8609a + #1820 passed (run 41408279513). Results recorded on #1819. Closing; never meant to merge.

@xiangfu0 xiangfu0 closed this Nov 2, 2026
@xiangfu0
xiangfu0 deleted the cs_gjy7snIsW9/ci-validate/datasource-pinot-client-with-1820 branch November 2, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant