Repository navigation
fix(pingdomtransaction): always send Active so checks can be un-paused - #687
Merged
msafwankarim merged 1 commit intoOct 6, 2026
Merged
Conversation
The Active field was only set when pausing, so with paused: false it stayed nil and omitempty dropped it from the request. Pingdom never received the un-pause, leaving transaction checks stuck paused. Set Active unconditionally from the Paused config so pause-state changes always reach Pingdom. Fixes stakater#686
Contributor
Author
|
I tested the functionality in a local cluster |
msafwankarim
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Active field was only set when pausing, so with paused: false it stayed nil and omitempty dropped it from the request. Pingdom never received the un-pause, leaving transaction checks stuck paused.
Set Active unconditionally from the Paused config so pause-state changes always reach Pingdom.
Fixes #686