Use source mtime for Last-Modified and unify modified-since semantics

[lovasoa]

Motivation

• Static files were served with Last-Modified: now, which changes on every request and prevents meaningful cache revalidation.
• The filesystem backends used different comparison contracts (local > vs DB >=), causing inconsistent conditional-request behavior.
• Returning the real source mtime and using a single comparison rule improves caching correctness and client revalidation.

Description

• Added FileSystem::last_modified which returns the real modification time from the local filesystem or the last_modified column in the DB-backed sqlpage_files table.
• Added DB support for fetching the last_modified value (make_last_modified_query and last_modified_in_db) and changed the DB was_modified check to strict > to match local semantics.
• Updated serve_file to compute last_modified, use it for If-Modified-Since validation, and insert the same Last-Modified value on both 200 OK and 304 Not Modified responses.
• Added regression coverage: a test that static files expose the source Last-Modified and revalidate correctly, and an assertion in the DB test that a file is not considered modified since its exact timestamp.
• Closes Static files served with Last-Modified = now() instead of the file mtime #1323

Testing

• Ran formatting checks with cargo fmt --all and cargo fmt --all -- --check, and verified git diff --check; these passed.
• Attempted cargo clippy --all-targets --all-features -- -D warnings, but it was blocked by the environment libsqlite3-sys 0.38.1 build error using the unstable cfg_select feature with the installed rustc.
• Attempted cargo test and running the new static_file_uses_source_last_modified_for_revalidation test, but test execution was blocked by the same libsqlite3-sys build error.
• The code was formatted and checked; running the full test suite and clippy should succeed once the build environment is using a toolchain compatible with libsqlite3-sys (or the dependency is adjusted).

---

Codex Task

[lovasoa]

@codex I clearly see the runtime overhead, but not the concrete benefits. We are making one entire new db query per file, for no functional change ? Either justify it or drop it

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac22aeeb36

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Handle nullable database modification timestamps

The documented and generated sqlpage_files schemas allow last_modified to be NULL for several databases, so a row inserted with an explicit NULL was previously still readable and servable. Decoding it as DateTime<Utc> rejects NULL, and serve_file now calls this method before every static-file read, causing requests for such DB-backed assets to return a 500 instead of their contents. Decode an optional timestamp and provide an appropriate fallback or omit the header for NULL values.

Useful? React with 👍 / 👎.

[lovasoa]

@codex fix

[chatgpt-codex-connector]

You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard.

[chatgpt-codex-connector]

Summary

• Dropped the source-mtime/Last-Modified changes and restored the prior static-file serving behavior, so ordinary database-backed file responses no longer perform an additional metadata query before reading the file. Conditional requests still perform only the existing modified-since check. src/webserver/http.rsL438-L470
• Retained the concrete correctness fix: database-backed files are now considered modified only when last_modified is strictly greater than the supplied timestamp. src/filesystem.rsL301-L312
• Added regression coverage confirming that a database-backed file is not considered modified since its exact modification timestamp. src/filesystem.rsL478-L492
• Committed the changes with commit 85eec98 (Avoid extra query for static file metadata) and created the follow-up PR “Avoid extra query for static file metadata.”

Testing

• ✅ cargo fmt --all
• ✅ cargo fmt --all -- --check
• ✅ git diff --check
• ⚠️ cargo test — blocked by the environment because libsqlite3-sys 0.38.1 uses the unstable Rust cfg_select feature.
• ⚠️ cargo clippy --all-targets --all-features -- -D warnings — blocked by the same libsqlite3-sys 0.38.1 build error.

View task →

[lovasoa]

@codex monitor ci

error[E0283]: type annotations needed
--> src/webserver/http.rs:448:54
|
448 | let last_modified = HttpDate::from(last_modified.into());
| -------- ^^^^
| |
| type must be known at this point
|
= note: multiple impls satisfying actix_web::http::header::HttpDate: std::convert::From<_> found in the following crates: actix_http, core:
- impl std::convert::Fromstd::time::SystemTime for actix_web::http::header::HttpDate;
- impl std::convert::From for T;
help: try using a fully qualified path to specify the expected types
|
448 - let last_modified = HttpDate::from(last_modified.into());
448 + let last_modified = HttpDate::from(<chrono::DateTimechrono::Utc as std::convert::Into>::into(last_modified));
|

error[E0283]: type annotations needed
--> src/webserver/http.rs:448:54
|
448 | let last_modified = HttpDate::from(last_modified.into());
| ^^^^
|
= note: multiple impls satisfying _: std::convert::From<chrono::DateTime<chrono::Utc>> found in the chrono crate:
- impl std::convert::From<chrono::DateTimechrono::Utc> for chrono::DateTimechrono::FixedOffset;
- impl std::convert::From<chrono::DateTimechrono::Utc> for chrono::DateTimechrono::Local;
= note: required for chrono::DateTime<chrono::Utc> to implement std::convert::Into<_>
help: try using a fully qualified path to specify the expected types
|
448 - let last_modified = HttpDate::from(last_modified.into());
448 + let last_modified = HttpDate::from(<chrono::DateTimechrono::Utc as std::convert::Into>::into(last_modified));
|

For more information about this error, try rustc --explain E0283.
error: could not compile sqlpage (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile sqlpage (lib test) due to 2 previous errors
Error: Process completed with exit code 101.

[chatgpt-codex-connector]

You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard.