[fix] Parse array is None if CFG conditionals when quering for memlets - #2487
Merged
tbennun merged 6 commits intoAug 12, 2026
Merged
Conversation
tbennun
requested changes
Aug 10, 2026
tbennun
left a comment
Collaborator
There was a problem hiding this comment.
Very minor change, otherwise lgtm
tbennun
enabled auto-merge
August 11, 2026 13:15
tbennun
approved these changes
Aug 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We encounter a case of CFG within a NestedSDFG where the condition is of the form
and where
arrayis a legit optional parameter. The SDFG -> STREE (and other) system relies on parsing the conditional AST to extract the arrays and propagate the memlets properly. The code ends up indace.sdfg.memlets_in_astwhere it is stated that the limitations are:We propose here to add a narrow parse of
array is Noneto strengthen the list. Implementation restrict the parsing to a single form to evade run away checks.