Skip to content

build_folder is serialized - #2465

Open
philip-paul-mueller wants to merge 11 commits into
spcl:mainfrom
philip-paul-mueller:serialize-build-folder
Open

build_folder is serialized#2465
philip-paul-mueller wants to merge 11 commits into
spcl:mainfrom
philip-paul-mueller:serialize-build-folder

Conversation

@philip-paul-mueller

@philip-paul-mueller philip-paul-mueller commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

SDFG.build_folder was not serialized, which was not a problem if it was not set explicitly.
If set explicitly it was also not serialized, thus the following code will fail:

sdfg = make_an_awesome_sdfg()
sdfg.build_folder = "/my/special/build_folder"
dolly = dace.SDFG.from_json(sdfg.to_json())
assert dolly.build_folder == sdfg.build_folder

This PR serialized build_folder is set otherwise it is not included, ensures compatibility with older versions.

Comment thread dace/sdfg/sdfg.py Outdated
@tbennun
tbennun added this pull request to the merge queue Aug 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants