Towards deterministic transformations: use ordered sets - #2445
Merged
acalotoiu merged 6 commits intoAug 11, 2026
Conversation
tehrengruber
marked this pull request as draft
July 20, 2026 09:59
tehrengruber
marked this pull request as ready for review
July 30, 2026 12:28
Collaborator
|
cscs-ci run |
acalotoiu
requested changes
Aug 6, 2026
acalotoiu
left a comment
acalotoiu
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Please fix merge conflict and then I add to merge queue
# Conflicts: # setup.py
Collaborator
|
cscs-ci run cscs/GPU |
Collaborator
|
cscs-ci run GPU |
Collaborator
|
cscs-ci run GPU |
acalotoiu
approved these changes
Aug 6, 2026
acalotoiu
enabled auto-merge
August 6, 2026 12:08
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses ordered sets (from https://pypi.org/project/ordered-set/) instead of regular python sets in order to get deterministic transformation results. There are likely more places so take this as a first step.