Fixed Multiple Return Values and Refined Validations - #2430
Open
philip-paul-mueller wants to merge 10 commits into
Open
Fixed Multiple Return Values and Refined Validations#2430philip-paul-mueller wants to merge 10 commits into
philip-paul-mueller wants to merge 10 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the return values were processed by using
sorted(), which sorted the tuple return values, i.e.__return_{id}, alphabetically. This has the effect that__return_11is ordered before__return_2. This PR changes this and ensures that they are in the correct order. Furthermore it speeds upCompiledSDFG._initialize_return_values()by not iterating over all arrays in teh SDFG but only through the actual return values.Furthermore, this PR refines the type rules in
sdfg.validation. Essentially it restricts return values toArrrays. This is done because their allocations is done NumPy it is limited by what NumPy can allocate.