Repository navigation
Fix local consts data ref - #8
Draft
Mittagskogel wants to merge 1 commit into
Draft
Mittagskogel wants to merge 1 commit into
Mittagskogel wants to merge 1 commit into
Conversation
Extend local constant tracking to indexed array elements and data-ref components, allowing substitution of scalar constant sub-expressions. Also tighten pointer target propagation: only track a pointer as a known alias when its RHS is a plain target or constant-indexed element; variable-indexed targets are left symbolic. Add regression tests in tests/inliner/optimizations_test.py. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the capabilities of the _track_local_consts() AST desugaring transformation.
By introducing a new spec generator find_indexed_dataref_component_spec(), we enable constant replacement of Part_Refs and Data_Refs like a(5) or a % b(4) % c(7,3). These Data_Refs get turned into specs like ('main', ('a', 5)) or (('main', 'a'), (a, ('b', 4), ('c', 7, 3)). Furthermore, the constant tracker can detect and replace array pointer references:
Additionally, we fix a bug in which variable pointer assignments are propagated. For example:
The fix checks whether Data_Ref nodes on the RHS of the pointer assignment contain any variables.
Ported from spcl/dace#2213