Upload return len - #49
Open
edvardxyz wants to merge 5 commits into
Open
Conversation
… and output length pointer
Lykkeberg
requested changes
Aug 19, 2026
| } | ||
|
|
||
| int vmem_download(int node, int timeout, uint64_t address, uint32_t length, char * dataout, int version, int use_rdp) { | ||
| ssize_t vmem_download(uint16_t node, uint32_t timeout, uint64_t address, char * dataout, uint32_t length, int use_rdp, int version, int verbosity) { |
Contributor
There was a problem hiding this comment.
You are breaking the API signature :-) but if you do, why not implement the verbosity argument as a const? This might help the linker in leaving out the printf() strings from the .const section in FLASH when compiled for the modules and not CSH.
|
|
||
| void vmem_progress(uint32_t total, uint32_t sofar) { | ||
| (void) total; | ||
| ssize_t vmem_upload(uint16_t node, uint32_t timeout, uint64_t address, const char * datain, uint32_t length, int use_rdp, int version, int verbosity) { |
Contributor
There was a problem hiding this comment.
Like for the vmem_download method I have the same comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align upload download API.
Added check for 64 bit address with version 1
Added a param_error.h to start making libparam a more coherent library.
Changed return values to ssize_t, not sure if we want to keep int or make it int64.
This is only necessary if we want to be able to return the count of the full 4GB possible upload and download length supported.
ssize_t would work on 64 bit client, not on 32 bit.
Forcing int64 would fix this