indexserver: truncate failure messages in status updates#1070
Merged
Conversation
stefanhengl
force-pushed
the
stefanhengl/assess-error-truncation
branch
4 times, most recently
from
1de4904 to
66d68d2
Compare
stefanhengl
force-pushed
the
stefanhengl/assess-error-truncation
branch
from
66d68d2 to
b671170
Compare
keegancsmith
approved these changes
Jun 5, 2026
| maxBytes-- | ||
| } | ||
|
|
||
| return s[:maxBytes] |
Member
There was a problem hiding this comment.
normally the end of logs are more interesting? We have some code (maybe in our monorepo) which was adapted from the stdlib which preserves the head and tail, then cuts in the middle. Would that be useful to use?
Member
Author
There was a problem hiding this comment.
Switched to middle truncation. I didn't use the helper from the monorepo because we don't need to support streaming.
Comment on lines
+767
to
+769
| for maxBytes > 0 && !utf8.RuneStart(s[maxBytes]) { | ||
| maxBytes-- | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncate failure messages to 12 KiB before sending index status updates to Sourcegraph. This limit is modeled after Kubernetes, which similarly truncates termination messages on the assumption that complete failure details are available in container logs.