Enable method overloading and overriding#70
Conversation
…int, byte, short, char)
… cases for method overriding.
…ion logic to code-generator.ts
…tatic field lookup logic.
Coverage report
Show files with reduced coverage 🔻
Test suite run success1134 tests passing in 64 suites. Report generated by 🧪jest coverage report action from 283510e |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements support for SwitchStatement and CastExpression, covering grammar updates, AST extraction, type checking, and bytecode generation. It also enhances method invocation to support overloading, overriding, and super calls, and enables the compiler to handle multiple class files. Feedback highlights several critical issues, including incorrect usage of the in operator and filter method in TypeScript, flawed JVM offset patching for switch instructions, and a missing string collision check in switch statements. Additionally, the reviewer identified logic errors in the final method override checks and inconsistent package naming conventions that could lead to lookup failures.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
LGTM, approved! |
Enable running multiple classes in java-slang.
Enable method overloading and overriding to support code as follows:
and