fix(api): drop the api_keys.role column default - #2197
Open
multipletwigs wants to merge 1 commit into
Open
multipletwigs wants to merge 1 commit into
multipletwigs wants to merge 1 commit into
Conversation
Every API-key create path now sends an explicit role, so the column default only hides a missing role. Marked breaking: the previous image relies on the default, so this ships alone after the explicit-role change is deployed.
Contributor
|
This was referenced Oct 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the
api_keys.rolecolumn default, split out of #2182 because the migration compatibility policy only accepts a breaking migration in a migrations-only PR.rolerequired on every create path.INSERT INTO api_keyson main and on refactor(api-keys): single dashboard-only create path with explicit roles #2182 namesrolewith a bound value (main fills it in the handlers,routes/api-keys/handlers.ts:254), so a rollback to the previous image still inserts cleanly.-- sdp:migration-compat: breakingbecause the check can't see the app-side value.Schema before/after (reconstructed from
0001_initial_schema.sql):Verification:
check:migration-compatpasses locally; scanned all 59INSERT INTO api_keyssites, none omitrole. Migration not applied to a live DB; CI DB suites not run locally.