fix(jazzy): cross-distro cv_bridge include; promote Jazzy CI to a blocking gate - #2
Merged
Merged
Conversation
…gate The Jazzy CI job failed because cv_bridge's C++ header was renamed cv_bridge.h -> cv_bridge.hpp in Jazzy (the .h was removed); Humble ships only .h. Include whichever exists via __has_include so the package builds on both distros. Verified in a ros:jazzy container: clean build + 25/25 tests (incl. the launch_testing integration test); Humble unchanged. Jazzy is now genuinely supported, so its build+test job is promoted from continue-on-error to a blocking gate alongside Humble.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the failing
build + test (jazzy)CI job.Cause:
cv_bridge's C++ header was renamedcv_bridge.h→cv_bridge.hppin Jazzy (the.hwas removed); Humble ships only.h.media_streamer_node.cpp/synthetic_4k_pub_node.cppincluded the.hform, so Jazzy failed atfatal error: cv_bridge/cv_bridge.h: No such file.Fix: portable
#if __has_include(<cv_bridge/cv_bridge.hpp>)guard —.hppon Jazzy,.hon Humble.Verified locally in a
ros:jazzycontainer: clean build + 25/25 tests (incl. the launch_testing integration test); Humble re-verified unchanged (25/25). Jazzy is now genuinely supported, so its build+test job is promoted fromcontinue-on-errorto a blocking gate.(arm64 job was never actually failing — its run concluded
success; the QEMU segfault in its log was a transient emulation hiccup. It stayscontinue-on-error.)