Repository navigation
chore: allow deps commit type in danger - #7413
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
5 of 9 tasks
This comment has been minimized.
This comment has been minimized.
octavian-snyk
force-pushed
the
ci/danger-allow-deps-type
branch
from
October 26, 2026 07:27
f3d11f3 to
9766c44
Compare
This comment has been minimized.
This comment has been minimized.
octavian-snyk
force-pushed
the
ci/danger-allow-deps-type
branch
from
October 26, 2026 08:58
9766c44 to
f19764a
Compare
This comment has been minimized.
This comment has been minimized.
octavian-snyk
force-pushed
the
ci/danger-allow-deps-type
branch
from
October 26, 2026 09:39
f19764a to
de252e1
Compare
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
octavian-snyk
force-pushed
the
ci/danger-allow-deps-type
branch
from
October 26, 2026 10:29
de252e1 to
e20e1f2
Compare
PR Reviewer Guide 🔍
|
robertolopezlopez
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Adds
depsto the commit types Danger accepts. This is temporary. The sync PR #7410 carries the commitdeps: bump yao-pkgfrom release-candidate, and Danger fails it becausedepsis not an allowed type. The next PR in the stack reverts this change.Where should the reviewer start?
The one-line regex change in
dangerfile.js.How should this be manually tested?
Rebase #7410 on this branch. The
Dangerstatus should pass.What's the product update that needs to be communicated to CLI users?
None.
Risk assessment
Low. CI-only change.
🤖 Generated with Claude Code
Note
Low Risk
CI-only Danger rule change with no runtime or product impact.
Overview
Temporarily extends Danger’s commit-message validation to accept the
depstype (e.g.deps: bump yao-pkg), so stacked/sync PRs aren’t blocked by CI while that convention exists on another branch.The change is a single regex update in
dangerfile.jsaddingdepsto the allowed conventional-commit prefixes; a follow-up PR is expected to remove it again.Reviewed by Cursor Bugbot for commit f3d11f3. Bugbot is set up for automated code reviews on this repo. Configure here.