Skip to content

chore: allow deps commit type in danger - #7413

Merged
octavian-snyk merged 1 commit into
mainfrom
ci/danger-allow-deps-type
Oct 26, 2026
Merged

octavian-snyk merged 1 commit into
mainfrom
ci/danger-allow-deps-type

Conversation

@octavian-snyk

@octavian-snyk octavian-snyk commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Adds deps to the commit types Danger accepts. This is temporary. The sync PR #7410 carries the commit deps: bump yao-pkg from release-candidate, and Danger fails it because deps is not an allowed type. The next PR in the stack reverts this change.

Where should the reviewer start?

The one-line regex change in dangerfile.js.

How should this be manually tested?

Rebase #7410 on this branch. The Danger status should pass.

What's the product update that needs to be communicated to CLI users?

None.

Risk assessment

Low. CI-only change.

🤖 Generated with Claude Code


Note

Low Risk
CI-only Danger rule change with no runtime or product impact.

Overview
Temporarily extends Danger’s commit-message validation to accept the deps type (e.g. deps: bump yao-pkg), so stacked/sync PRs aren’t blocked by CI while that convention exists on another branch.

The change is a single regex update in dangerfile.js adding deps to the allowed conventional-commit prefixes; a follow-up PR is expected to remove it again.

Reviewed by Cursor Bugbot for commit f3d11f3. Bugbot is set up for automated code reviews on this repo. Configure here.

@octavian-snyk
octavian-snyk requested review from a team as code owners October 26, 2026 07:18
@snyk-io

snyk-io Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@octavian-snyk octavian-snyk mentioned this pull request Oct 26, 2026
5 of 9 tasks
@snyk-pr-review-bot

This comment has been minimized.

@octavian-snyk
octavian-snyk force-pushed the ci/danger-allow-deps-type branch from f3d11f3 to 9766c44 Compare October 26, 2026 07:27
@octavian-snyk octavian-snyk changed the title ci: allow deps commit type in danger chore: allow deps commit type in danger Oct 26, 2026
@snyk-pr-review-bot

This comment has been minimized.

@octavian-snyk
octavian-snyk force-pushed the ci/danger-allow-deps-type branch from 9766c44 to f19764a Compare October 26, 2026 08:58
@snyk-pr-review-bot

This comment has been minimized.

@octavian-snyk
octavian-snyk force-pushed the ci/danger-allow-deps-type branch from f19764a to de252e1 Compare October 26, 2026 09:39
@snyk-pr-review-bot

This comment has been minimized.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@octavian-snyk
octavian-snyk force-pushed the ci/danger-allow-deps-type branch from de252e1 to e20e1f2 Compare October 26, 2026 10:29
@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 3 relevant code sections from 3 files (average relevance: 0.64)

🤖 Repository instructions applied (from AGENTS.md)

@octavian-snyk
octavian-snyk merged commit 4638065 into main Oct 26, 2026
10 checks passed
@octavian-snyk
octavian-snyk deleted the ci/danger-allow-deps-type branch October 26, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants