Repository navigation
test: fix Maven component metadata suite compilation - #7411
Open
nico-incubiq wants to merge 1 commit into
Open
nico-incubiq wants to merge 1 commit into
nico-incubiq wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
danskmt
force-pushed
the
fix/cli-1949-maven-metadata-test-teardown
branch
from
October 26, 2026 08:40
206adf0 to
6a1cd02
Compare
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unblocks compilation of the Maven component-metadata acceptance suite. #7352 added
FakeServertyping on October 13 (5680a5ce), exposing a pre-existingPromise<unknown>resolver incompatible withclose(() => void). DeclarePromise<void>.The suite protects metadata flag forwarding, hash/distribution labels, the flag-off control, and repository credential stripping.
Where should the reviewer start?
test/jest/acceptance/snyk-test/maven-include-component-metadata.spec.ts, teardown.CLI-1949 tracks the external skip and an earlier missing Axis distribution-URL assertion. The October 22 retry failed compilation before executing tests; this fix does not establish that the earlier assertion passes.
How should this be manually tested?
With Maven and a native built CLI, run this Jest suite using
TEST_SNYK_COMMAND.Pending external action: remove only
maven-include-component-metadata\.spec\.tsfrom CircleCI contextteam-cli-workflow-context→TEST_SNYK_IGNORE_LIST, preserving other exclusions. No CircleCI configuration access in this session; live value unverified.Passed:
make format,make lint; reported TS2345 reproduced, then eliminated. Runtime validation blocked by missing Maven/macOS binary on Linux. Snyk Code scan blocked by authentication.What's the product update that needs to be communicated to CLI users?
None; test-only change.
Risk assessment (Low | Medium | High)?
Low. No production changes; existing assertions remain intact.
Note
Low Risk
Test-only typing fix; no runtime or production impact.
Overview
Fixes a TypeScript compile error in the Maven
--include-component-metadataacceptance suite teardown by typing theafterAllshutdown promise asPromise<void>.That aligns the promise resolver passed to
server.close(res)withFakeServer.close’s() => voidcallback after stricterFakeServertyping surfaced the mismatch. No test behavior or production code changes.Reviewed by Cursor Bugbot for commit 206adf0. Bugbot is set up for automated code reviews on this repo. Configure here.