Skip to content

adding the correct image tag for e2e tests - #2565

Open
nluaces wants to merge 2 commits into
skupperproject:mainfrom
nluaces:align-image-tags-with-e2e-tests
Open

adding the correct image tag for e2e tests#2565
nluaces wants to merge 2 commits into
skupperproject:mainfrom
nluaces:align-image-tags-with-e2e-tests

Conversation

@nluaces

@nluaces nluaces commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Improved automated end-to-end environment setup by consistently applying image and registry settings across both test clusters.
    • Updated default component versions for local and automated development workflows.
    • Added a convenient command for inspecting configured build variables, making troubleshooting and environment verification easier.
    • Enhanced consistency between development and testing environments.

@nluaces nluaces self-assigned this Sep 1, 2026
@nluaces nluaces added the do-not-merge Work In Progress label Sep 1, 2026
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: c69a37ff-d24b-4b6f-b662-b0056b12e2e8

📥 Commits

Reviewing files that changed from the base of the PR and between f7ea810 and 5067bca.

📒 Files selected for processing (1)
  • Makefile

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The change updates default Skupper image tags, adds a Make target that prints variable values, and passes image and registry settings to east and west E2E kind cluster creation commands.

Changes

E2E cluster configuration

Layer / File(s) Summary
Image configuration and cluster wiring
.circleci/config.yml, Makefile
IMAGE_TAG and ROUTER_IMAGE_TAG use new defaults. The print-% target echoes Make variables. CircleCI passes image tags and registry values to both cluster setup commands.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: 🟡 Moderate · up to 5067b

The E2E workflow still loads images under one tag while deploying them under another, which can prevent clean test clusters from starting. The PR is not merge-ready until the image tags are aligned.

Suggested reviewers: fgiorgetti, c-kruse

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: aligning image tags for E2E tests.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 41d908a5-329f-45f4-8f1a-ce05bf01adc6

📥 Commits

Reviewing files that changed from the base of the PR and between 06223ca and f7ea810.

📒 Files selected for processing (2)
  • .circleci/config.yml
  • Makefile

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread Makefile Outdated
@nluaces nluaces removed the do-not-merge Work In Progress label Sep 2, 2026
@nluaces nluaces changed the title WIP: adding the correct image tag for e2e tests adding the correct image tag for e2e tests Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant