fix: 🐛 Fix listeners and connectors mock handlers - #601
Merged
pierpman merged 1 commit intoAug 17, 2026
Merged
Conversation
fgiorgetti
approved these changes
Aug 13, 2026
fgiorgetti
left a comment
Member
There was a problem hiding this comment.
Tested using mock data and real network observer.
c-kruse
approved these changes
Aug 13, 2026
pwright
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
getListenersandgetConnectorsmock handlers returning empty results whenlimitis included in the query string.The handlers were passing the full query params object (including pagination keys like
limit) directly tofilterResults. Since listener and connector records have nolimitfield, every record was dropped.The fix follows the pattern already used by all other list handlers: destructure
limitandoffsetout of the query params before passing the remaining keys tofilterResults.Issue
Additional context (optional)
Affected requests example:
Previously returned
{ results: [], count: 0 }. Now correctly returns all matching connectors/listeners.How to test
yarn startshippingservice.Screenshots
Before:

After:
