Skip to content

added a UML folder with AmbientLight.uml and DirectionalLight.uml#8

Open
jharraf wants to merge 1 commit into
siue-caos:masterfrom
jharraf:master
Open

added a UML folder with AmbientLight.uml and DirectionalLight.uml#8
jharraf wants to merge 1 commit into
siue-caos:masterfrom
jharraf:master

Conversation

@jharraf

@jharraf jharraf commented Nov 14, 2017

Copy link
Copy Markdown

No description provided.

@gneisswork

Copy link
Copy Markdown

It would be good to create class for Point3D and Color and use those classes in a Light class. The Light class can be the base for AmbientLight and DirectionalLight

@Settlemoir

Copy link
Copy Markdown

I am thinking back to learning interfaces in 150, and would this be a good place to use one? Lights, Shapes, and the Camera are all somewhat different, but are all going to have positions (x,y,z) in a scene, so would it make sense to make a Prop interface?

Lets say there was a a Prop interface that just required the implementation of getters and setters for X, Y, Z coordinates.

Then, Lights, Shapes, and the Camera classes could implement the Prop interface and I think a scene could then just be fed an array or list of Props

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants