added a UML folder with AmbientLight.uml and DirectionalLight.uml#8
Open
jharraf wants to merge 1 commit into
Open
added a UML folder with AmbientLight.uml and DirectionalLight.uml#8jharraf wants to merge 1 commit into
jharraf wants to merge 1 commit into
Conversation
|
It would be good to create class for |
|
I am thinking back to learning interfaces in 150, and would this be a good place to use one? Lights, Shapes, and the Camera are all somewhat different, but are all going to have positions (x,y,z) in a scene, so would it make sense to make a Prop interface? Lets say there was a a Prop interface that just required the implementation of getters and setters for X, Y, Z coordinates. Then, Lights, Shapes, and the Camera classes could implement the Prop interface and I think a scene could then just be fed an array or list of Props |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.