Repository navigation
Fix limitFunction queue clearing - #109
Merged
sindresorhus merged 1 commit intoAug 31, 2026
Merged
Conversation
lprnmns
marked this pull request as ready for review
August 31, 2026 16:21
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
limitFunction()accepts and documentsrejectOnClear, but the returned function does not exposeclearQueue(). Callers therefore cannot trigger the promised rejection behavior, and attempting to do so throwsTypeError: limitedFunction.clearQueue is not a function.Fix
Expose the internal limiter's existing
clearQueuemethod on the returned limited function, reflect it in the TypeScript return type, and document the method. This reuses the established queue-clearing behavior without changing scheduling or call signatures.Tests
npm exec ava -- --match='limitFunction exposes clearQueue'— passed (1 test)npm exec tsd— passednpm test— passed (23 AVA tests; one pre-existing XO TODO warning)git diff --check— passedCompatibility
This adds a non-enumerable method to functions returned by
limitFunction(). Existing calls and concurrency behavior are unchanged; clearing delegates to the internal limiter's existingrejectOnClearsemantics.Related issue
No linked issue. Reproduced on
mainatdf476048d023ff868cd45b35ee47f5fb0ca2b25a; live issue/PR and focused duplicate searches found no competing work.