Repository navigation
Expose SQL and parameters to page plugins - #3039
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1817.
Page plugins can now receive the SQL and parameters used for table, row and query pages through the four page-extra hooks. Output renderers also receive
params, andrender_template()accepts an explicitplugin_contextdictionary. Stored-query parameters include the values actually bound by SQLite, so plugins can replay the query without resolving magic parameters again; template variables and JSON extras retain their existing contents.Validation on Linux with Python 3.12:
pytest -n 4 -m "not serial"— 2917 passed, 86 skipped, 6 xfailed, 15 xpassed;pytest -m serial— 40 passed.AI assistance: implemented and validated using Codex.