Repository navigation
Run the duplicate-action message assertion - #3030
Open
dylanpulver wants to merge 1 commit into
Open
dylanpulver wants to merge 1 commit into
dylanpulver wants to merge 1 commit into
Conversation
The assertion sat inside the `with pytest.raises(StartupError)` block, after the call that raises, so it never executed. Moving it below the block lets it check the message it was written to check.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_hook_register_actions_no_duplicateshas its assertion inside thewith pytest.raises(StartupError)block, below the call that raises:invoke_startup()raises, so the assertion is never reached and the error message is unchecked. (ex.valueis also only populated after the block exits.)Verified by replacing the expected string with a deliberately wrong one:
So the message does match once the assertion runs.
tests/test_plugins.pyis 161 passed, 4 skipped before and after, andblack --checkis clean.