Repository navigation
Conversation
The class diagram PNGs had black lines on a transparent background, which made them barely readable in GitHub's dark theme. Flatten them onto a white background with a small margin. Fixes simatic-ax#56
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56
The class diagrams in the README (
state.png,transition.png,guard.png,logger.png) have black lines on a transparent background, so they are barely readable in GitHub's dark theme. This PR flattens them onto a white background with a small 10px margin. The diagram contents are unchanged.statecontroller.pngalready had an opaque background and is left as is.Checked in GitHub's dark theme on my fork: the lines and arrows are now clearly visible.
If you would prefer theme-aware diagrams, I could convert them to Mermaid (like
docs/classdiagram.md) in a follow-up.