Repository navigation
Prepare the 2.0.0 release - #372
Merged
Merged
Conversation
Beyond about 1e102 the cube from Oklab into LMS overflows, infinities of both signs meet as NaN, and clamping passed the NaN through, so toGamut with Clip threw IllegalArgumentException for a color ColorValue had accepted. A NaN channel now clamps to 0, as the other methods already reach by searching. The KDoc states what remains: past about 1e102 the result is unrelated to the color and from about 1e150 black, and near black ClosedForm finds the edge less precisely than the color holds.
1.2.1 was merged but never published, yet CHANGELOG and the migration table named it as where codes.side:colorpicker stops. The 2.0 section also had no Dependencies entry, where 1.2.1's had one; it lists what each artifact adds. README gains the two limits of gamut mapping's arithmetic.
A vulnerability had no reporting path but a public issue; SECURITY.md gives the address CODE_OF_CONDUCT already publishes. The Pages config excluded a folder that is not in the repository.
CI checked that each module's POMs exist after publishToMavenLocal, which says nothing of whether an app can use them, and its iOS framework is static, which defers symbol resolution to the app. tools/consumer is a build of its own that depends on colorpicker-material3 alone and links a dynamic iOS framework against the published artifacts. With -PpickerRepo=snapshots it reads the Central snapshot repository instead of Maven Local.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toGamutwithClipno longer throws for a colorColorValueaccepted. Beyond about 1e102 the conversion into LMS overflows to NaN, which clamping passed through, and the mapped color failed its own check withIllegalArgumentException. A NaN channel clamps to 0, asCssandChromaReductionalready reached by searching. A test fails on master.ChromaReduction's default solver finds the edge less precisely than the color holds, whileEdgeSolver.Iterativekeeps lightness and hue.codes.side:colorpickerstops at 1.2.0. 1.2.1 was merged but never published, and CHANGELOG and the migration table named it. Its CHANGELOG section says so.SECURITY.mdgives a private reporting path, the addressCODE_OF_CONDUCT.mdalready publishes. The Pages config drops an exclude for a folder the repository does not have.tools/consumeris a build of its own that depends oncolorpicker-material3alone and links a dynamic iOS framework against whatpublishToMavenLocaljust published, where the library's own framework is static and leaves symbol resolution to the app. With-PpickerRepo=snapshotsit reads the Central snapshot repository instead.apiCheckandcheckNoMaterialpass, andtools/consumercompiles for JVM against a local publication. The iOS link runs here in CI.