Repository navigation
Put imports back in the repository's order - #371
Merged
Merged
Conversation
The rename to Oklch left the import ahead of Okhsl in three files, where plain ASCII order puts it after, and two tests listed kotlin.* after kotlinx.*, as the IDE lays imports out. ComposeBridgeTest also kept the Rgb and toGamut imports after the code that used them went.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports are in plain ASCII order, aliases last. Five files had drifted:
PlaneSurface.kt,PlaneWorkersTest.ktandPlaneTimingTest.kt: the rename toOklchleft its import ahead ofOkhsl.PlaneRastersTest.ktandPlaneBuildCancellationTest.kt:kotlin.*came afterkotlinx.*, as the IDE lays imports out.ComposeBridgeTestalso drops theRgbandtoGamutimports, unused since the code that needed them went. No file in the repository is out of order now.color-compose(14) andcolorpicker-foundation(313) pass on JVM, and the foundation's wasm sources compile.