Repository navigation
Read a colorful color's missing hue as 0, as it is drawn - #370
Merged
Merged
Conversation
The state gave any missing hue the one it remembered, which is right for a grey but not for hsl(none 80 50): that is drawn red, as CSS reads none as 0, while the hue slider showed the remembered 200, and the first saturation edit wrote 200 in and turned the swatch blue. Only a grey's missing hue, one its space calls powerless, now takes the remembered hue; any other reads 0, on the slider and in an edit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A missing hue took the remembered one whatever the color. That is right for a grey, but
hsl(none 80 50)is drawn red, as CSS readsnoneas 0, while its hue slider showed the remembered 200, and the first saturation edit wrote 200 in and turned the swatch blue.Only a grey's missing hue, one its space calls powerless, now takes the remembered hue. Any other reads 0, on the slider and in an edit, so
hsl(none 80 50)shows hue 0 and a saturation edit giveshsl(0 70 50). A grey still brings its remembered hue back when its saturation rises.The colorful case fails on master.
apiCheck,checkNoMaterialand the 30 screenshot baselines pass.