Skip to content

Read a colorful color's missing hue as 0, as it is drawn - #370

Merged
smelfungus merged 1 commit into
masterfrom
missing-hue-reads-zero
Sep 28, 2026
Merged

smelfungus merged 1 commit into
masterfrom
missing-hue-reads-zero

Conversation

@smelfungus

Copy link
Copy Markdown
Member

A missing hue took the remembered one whatever the color. That is right for a grey, but hsl(none 80 50) is drawn red, as CSS reads none as 0, while its hue slider showed the remembered 200, and the first saturation edit wrote 200 in and turned the swatch blue.

Only a grey's missing hue, one its space calls powerless, now takes the remembered hue. Any other reads 0, on the slider and in an edit, so hsl(none 80 50) shows hue 0 and a saturation edit gives hsl(0 70 50). A grey still brings its remembered hue back when its saturation rises.

Module JVM Android host wasm
color 242 229 229
color-compose 14 14 14
colorpicker-foundation 313 157 157
colorpicker-material3 177 4 4

The colorful case fails on master. apiCheck, checkNoMaterial and the 30 screenshot baselines pass.

The state gave any missing hue the one it remembered, which is right for a grey but not for hsl(none 80 50): that is drawn red, as CSS reads none as 0, while the hue slider showed the remembered 200, and the first saturation edit wrote 200 in and turned the swatch blue. Only a grey's missing hue, one its space calls powerless, now takes the remembered hue; any other reads 0, on the slider and in an edit.
@smelfungus
smelfungus merged commit ca2e844 into master Sep 28, 2026
2 checks passed
@smelfungus
smelfungus deleted the missing-hue-reads-zero branch September 28, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant