Remove Connection::create_native_widget_from_ptr - #394
Merged
mrobinson merged 1 commit intoSep 20, 2026
Merged
Conversation
This is unecessary now that `RawWindowHandle` is supported by default. Servo doesn't use it. There still might be a use for a kind of a surface made via an unsafe unretained handle, but the way that `wgpu` handles this is with `SurfaceTargetUnsafe::RawHandle` which is based on `RawWindowHandle`. surfman could do the same. Still it would be better to implement this after the API rework. Signed-off-by: Martin Robinson <martin@abandonedwig.info>
sagudev
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is unecessary now that
RawWindowHandleis supported by default.Servo doesn't use it. There still might be a use for a kind of a surface
made via an unsafe unretained handle, but the way that
wgpuhandlesthis is with
SurfaceTargetUnsafe::RawHandlewhich is based onRawWindowHandle. surfman could do the same. Still it would be betterto implement this after the API rework.