Collapse various adapter construction methods into one that takes a preference - #393
Merged
Merged
Conversation
mrobinson
force-pushed
the
collapse-adapter-constructors
branch
from
September 19, 2026 15:26
36f163e to
494c256
Compare
sagudev
approved these changes
Sep 20, 2026
Comment on lines
+22
to
+26
| /// Prefer a high-power adapter. | ||
| #[default] | ||
| High, | ||
| /// Prefer a low-power adapter. | ||
| Low, |
Member
There was a problem hiding this comment.
Can we have more descriptive names here (like we did for WGL) and like webgpu
Suggested change
| /// Prefer a high-power adapter. | |
| #[default] | |
| High, | |
| /// Prefer a low-power adapter. | |
| Low, | |
| /// Prefer a high-power adapter. | |
| #[default] | |
| HighPerformance, | |
| /// Prefer a low-power adapter. | |
| LowPower, |
Member
Author
There was a problem hiding this comment.
Sure! That's done now.
…reference This removes a lot of code, matches more closely how `wgpu` creates creates adapters, and will make it easier to make further changes to all of these interfaces. Signed-off-by: Martin Robinson <mrobinson@abandonedwig.info>
mrobinson
force-pushed
the
collapse-adapter-constructors
branch
from
September 20, 2026 08:27
494c256 to
3399e6d
Compare
mrobinson
enabled auto-merge
September 20, 2026 08:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a lot of code, matches more closely how
wgpucreatescreates adapters, and will make it easier to make further changes to all
of these interfaces.