[codex] Resolve localized Word list style IDs - #213
Draft
stefsava wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes HTML list rendering for templates saved by localized versions of Microsoft Word. Word may rewrite built-in list style IDs such as
ListNumberandListBulletto localized IDs likeNumeroelencoandPuntoelenco, while keeping the canonical style names inword/styles.xml.The first commit adds a localized executable fixture that reproduces the failure. The second commit resolves the actual style ID through
word/styles.xmlbefore looking up the numbering definition.Validation
bundle exec ruby -Itest test/executable_test.rb -n test_generate_document_from_localized_template_output_to_filebundle exec ruby -Itest test/executable_test.rbbundle exec rake testNote:
Gemfile.lockwas modified locally for the test environment and intentionally excluded from this PR.